ci: run fresh-install e2e in release workflow - #6
Open
liwenjie200543 wants to merge 2 commits into
Open
Conversation
Owner
|
Review 结论:Request changes。\n\n[P1] 新增的 Fresh-install E2E 使用了写死的 mac-arm64 路径,但 release workflow 运行在未固定架构的 macos-latest 上。如果 runner 产出 mac-x64,测试会在启动应用前直接失败。\n\n建议复用 package-smoke.mjs 中动态查找 dist/electron/mac*/Folio.app 的逻辑,或在 workflow 中显式固定构建架构。相关位置:apps/electron/e2e/fresh-install.mjs:28-31,以及本 PR 新增的 .github/workflows/release.yml:78-80。\n\n非阻塞建议:scripts/release-check.mjs 还包含 test:v5,而 release.yml 仍未执行它;如果目标是让发布 workflow 覆盖完整 release-check,建议一并补齐。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The release gate already defines
test:fresh-install, but.github/workflows/release.ymldid not execute it. This meant regressions affecting a brand-new user's first launch could pass the existing unit, build, and packaged smoke checks undetected.The new step runs after packaging and packaged smoke, ensuring the actual packaged
Folio.appis tested before checksum verification and release asset upload.Verification
git diff --check— passedbun run typecheck— passed for all workspaces