Skip to content

ci: run fresh-install e2e in release workflow - #6

Open
liwenjie200543 wants to merge 2 commits into
helsome:mainfrom
liwenjie200543:codex/ci-fresh-install-release-gate
Open

ci: run fresh-install e2e in release workflow#6
liwenjie200543 wants to merge 2 commits into
helsome:mainfrom
liwenjie200543:codex/ci-fresh-install-release-gate

Conversation

@liwenjie200543

Copy link
Copy Markdown

Summary

  • run the packaged-app fresh-install E2E in the Release workflow
  • verify onboarding, disclaimer gating, skip flow, workbench rendering, and restart persistence before publishing
  • update the V5 blocker sweep to reflect the new CI coverage

Why

The release gate already defines test:fresh-install, but .github/workflows/release.yml did not execute it. This meant regressions affecting a brand-new user's first launch could pass the existing unit, build, and packaged smoke checks undetected.

The new step runs after packaging and packaged smoke, ensuring the actual packaged Folio.app is tested before checksum verification and release asset upload.

Verification

  • git diff --check — passed
  • bun run typecheck — passed for all workspaces

@helsome

helsome commented Sep 2, 2026

Copy link
Copy Markdown
Owner

Review 结论:Request changes。\n\n[P1] 新增的 Fresh-install E2E 使用了写死的 mac-arm64 路径,但 release workflow 运行在未固定架构的 macos-latest 上。如果 runner 产出 mac-x64,测试会在启动应用前直接失败。\n\n建议复用 package-smoke.mjs 中动态查找 dist/electron/mac*/Folio.app 的逻辑,或在 workflow 中显式固定构建架构。相关位置:apps/electron/e2e/fresh-install.mjs:28-31,以及本 PR 新增的 .github/workflows/release.yml:78-80。\n\n非阻塞建议:scripts/release-check.mjs 还包含 test:v5,而 release.yml 仍未执行它;如果目标是让发布 workflow 覆盖完整 release-check,建议一并补齐。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants