Repository navigation
fix(gfql): preserve scalar reentry across continuation matches - #2253
Merged
Merged
Conversation
lmeyerov
force-pushed
the
fix/gfql-2252-scalar-carry
branch
from
October 29, 2026 15:27
cb2f6e0 to
e131383
Compare
This was referenced Oct 29, 2026
added 9 commits
October 31, 2026 17:35
lmeyerov
force-pushed
the
fix/gfql-2252-scalar-carry
branch
from
November 1, 2026 00:37
e131383 to
ee08a09
Compare
This was referenced Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WITHscalar carries through surviving Polars edge steps, including multi-edge and forward/reverse/undirected traversal.Validation
issue_2252 or issue_1413 or reentryselection: 141 passed, 1,591 deselected.same_pathreentry and carry dispatch. The same-output control used 3 warmups/7 samples; pooled medians were 127.983/127.978 ms for positive and 90.988/95.610 ms for empty (base/candidate). This is bounded context, not a speed or statistical-equivalence claim.std::bad_allocwhile foreignVLLM::EngineCoreheld 60,103 MiB. No cuDF parity claim.Identity and review state
a649e05f20a2457a024722b78b6f99d3ab0aeb46e131383a34cda7985db223440c25a32203d050816cefa818e73d92700242d3ed1fa1d75d520b047b