build: make GPG signing conditional in PublishingConventionPlugin for local publishing - #1743
Open
dkhawk wants to merge 1 commit into
Open
build: make GPG signing conditional in PublishingConventionPlugin for local publishing#1743dkhawk wants to merge 1 commit into
dkhawk wants to merge 1 commit into
Conversation
… local publishing - Wrap signAllPublications() in an if-check verifying whether signing.keyId or signing.secretKeyRingFile is configured, preventing local ./gradlew publishToMavenLocal builds from failing with missing .asc signature errors when GPG credentials are omitted. - Keep full publication signing active whenever GPG credentials are provided on CI or release pipelines.
dkhawk
force-pushed
the
build/conditional-gpg-signing
branch
from
August 5, 2026 18:13
54a5cf2 to
396aad6
Compare
Contributor
Code Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
When developers run
./gradlew publishToMavenLocalon their local machines without configuring GPG signing credentials (signing.keyId,signing.secretKeyRingFile), the build fails with:This occurred because
signAllPublications()inPublishingConventionPlugin.ktwas invoked unconditionally.This PR wraps
signAllPublications()so that it only signs whensigning.keyIdorsigning.secretKeyRingFileis present and non-empty:Verification
./gradlew publishToMavenLocalacross all modules: BUILD SUCCESSFUL without.ascsignature errors.~/.m2/repository/com/google/maps/android/.