Repository navigation
fix: check field value is non-null in GenericData.containsKey - #2191
Merged
Merged
Conversation
whowes
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2187
In
GenericData, declared@Keyfields withnullvalues are treated as absent from the map (excluded fromentrySet()andkeySet()). PR #2151 changedGenericData.containsKey(Object)to checkclassInfo.hasFieldInfo(fieldName), which returnedtrueeven when the declared field's value on the instance wasnull, violating theMap/Setcontract and breaking callers checking field presence.Update
GenericData.containsKey(Object)to checkfieldInfo.getValue(this) != nullwhenfieldInfo != null, matchingDataMap.containsKey()andGenericData.entrySet().The pom changes are unrelated to the fix but they are required to pass the CI. Because Github runner recently upgraded to Maven 3.10 which errors out on duplicated plugin configurations.