fix(modules): sync folder, net-lb-int, net-lb-proxy-int, spanner-instance, and cloud-run-v2 from upstream CFF - #276
Draft
aghassemlouei wants to merge 1 commit into
Draft
aghassemlouei wants to merge 1 commit into
aghassemlouei wants to merge 1 commit into
Conversation
…ance, and cloud-run-v2 from upstream CFF
17 of 19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Syncs the five modules whose remediation fixes already exist in upstream Cloud Foundation Fabric (
GoogleCloudPlatform/cloud-foundation-fabricmaster), split out from #274:modules/folder: Pulls upstream CFFmasterupdates, including splitting"CA_PROTECTED_B, IL5, HIPAA, HITRUST"into separate list items inassured_workload_config.compliance_regimevalidation.modules/net-lb-int: Pulls upstream CFFmasterupdates, including fixinghttp2_health_check(local.hc.http2.*) andssl_health_check(local.hc.ssl.*) attribute references.modules/net-lb-proxy-int: Pulls upstream CFFmasterupdates, removing brokenar.backend_service_configandlocal.bs_conntrackreferences inbackend-service.tfand guardingvar.backend_service_config.backends == nullinvariables.tf.modules/spanner-instance: Pulls upstream CFFmasterupdates, including dynamicconditionblocks ongoogle_spanner_instance_iam_binding.modules/cloud-run-v2: Pulls upstream CFFmasterupdates and removes the deprecated unreferencedmodules/cloud-run(v1) directory.versions.tfprovider constraints (>= 6.21.0, < 7.0.0) across the synced modules to avoid provider version conflicts with FAST stages and blueprints.Type of Change
Deployment & Compliance Impact
Checklist
Code Quality & Reusability
modules/orfast/can be leveraged for this change.documentation/naming-convention.md.Documentation
README.mdof the modified module or blueprint.Security
Testing
Testing Performed
hclfmtand regeneratedREADME.mddocumentation withtools/tfdoc.pyacross all synced modules.python3 -m unittest discover -s tests/tools(35/35 unit tests passing, includingtest_synced_upstream_cff_modules_fixes).