fix(modules): fix IAM key delimiters, log filters, and conditions in custom modules - #275
Merged
Merged
Conversation
17 of 19 tasks
aghassemlouei
marked this pull request as ready for review
October 2, 2026 15:55
aghassemlouei
enabled auto-merge (squash)
October 2, 2026 15:55
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes logic defects, IAM key delimiter collisions, and conditional binding support across Stellar Engine custom modules (
modules/cis-log-alerts,modules/cis-log-metrics,modules/intrusion-detection-system,modules/organization-se, andmodules/spanner-instance-se), split out from #274:modules/cis-log-alerts: Exposesvar.notification_channelsand concatenates additional channels with the default email notification channel; useseach.keyinstead of the literal string"each.key"for alert condition display names.modules/cis-log-metrics: Fixes operator precedence parentheses in theproject-owner-logCIS log filter expression.modules/intrusion-detection-system: Fixes inverted ternary (var.create_service_networking_connection ? 1 : 0) ongoogle_service_networking_connection.private_vpc_connection.modules/organization-se: Uses//delimiter iniam-bpa:${principal}//${role}keys, wraps the comprehension inmerge([...])so empty maps do not fail, and anchors theorganization_idvalidation regular expression (^organizations/[0-9]+$).modules/spanner-instance-se: Addsconditionsupport tovar.iam_bindingsandgoogle_spanner_instance_iam_binding.authoritative.tests/tools/test_blueprint_and_module_validations.py: Adds unit tests covering all five custom Stellar Engine modules.Type of Change
Deployment & Compliance Impact
Checklist
Code Quality & Reusability
modules/orfast/can be leveraged for this change.documentation/naming-convention.md.Documentation
README.mdof the modified module or blueprint.Security
Testing
Testing Performed
hclfmtacross all five custom Stellar Engine modules.python3 -m unittest discover -s tests/tools(35/35 unit tests passing, includingtest_custom_stellar_engine_modules_validations).