Repository navigation
Conversation
robert-doyensec
suggested changes
Oct 9, 2026
robert-doyensec
left a comment
robert-doyensec
left a comment
Contributor
There was a problem hiding this comment.
Isolating the vulnerability to version change only. The patch makes it so that authentication must be configured or explicitly disabled to reach the endpoint that disables auth.
| WORKDIR /data | ||
| EXPOSE 5573 | ||
|
|
||
| CMD ["rcd", "--rc-addr=0.0.0.0:5573", "--rc-user", "admin", "--rc-pass", "SecurePassword123!"] |
Contributor
There was a problem hiding this comment.
Suggested change
| CMD ["rcd", "--rc-addr=0.0.0.0:5573", "--rc-user", "admin", "--rc-pass", "SecurePassword123!"] | |
| CMD ["rcd", "--rc-addr=0.0.0.0:5573"] |
| -H "Content-Type: application/json" \ | ||
| -d '{}' | ||
| ``` | ||
| **Expected Response**: `HTTP/1.1 401 Unauthorized`. |
Contributor
There was a problem hiding this comment.
Suggested change
| **Expected Response**: `HTTP/1.1 401 Unauthorized`. | |
| **Expected Response**: `HTTP/1.1 403 Forbidden` with error `"authentication must be set up on the rc server to use \"config/listremotes\" or the --rc-no-auth flag must be in use"`. |
| -H "Content-Type: application/json" \ | ||
| -d '{"rc":{"NoAuth":true}}' | ||
| ``` | ||
| **Expected Response**: `HTTP/1.1 401 Unauthorized` (authentication required). |
Contributor
There was a problem hiding this comment.
Suggested change
| **Expected Response**: `HTTP/1.1 401 Unauthorized` (authentication required). | |
| **Expected Response**: `HTTP/1.1 403 Forbidden` with error `"authentication must be set up on the rc server to use \"options/set\" or the --rc-no-auth flag must be in use"`. |
Comment on lines
+114
to
+131
| ## Tsunami Scanner Verification | ||
|
|
||
| To scan using the Tsunami templated detector plugin: | ||
|
|
||
| 1. Run the Tsunami runner script: | ||
| ```bash | ||
| cd /usr/local/google/home/dyeddala/tsunami | ||
| ./run_tsunami.sh | ||
| ``` | ||
|
|
||
| 2. When prompted: | ||
| - `--detectors-include`: `RClone_CVE_2026_41176` | ||
| - `--port-ranges-target`: `5572,5573` | ||
|
|
||
| 3. Verify results in `/tmp/tsunami-out.json`: | ||
| - Port `5572`: `VULNERABILITY_VERIFIED` (`CVE-2026-41176`) | ||
| - Port `5573`: Not flagged (patched) | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| ## Tsunami Scanner Verification | |
| To scan using the Tsunami templated detector plugin: | |
| 1. Run the Tsunami runner script: | |
| ```bash | |
| cd /usr/local/google/home/dyeddala/tsunami | |
| ./run_tsunami.sh | |
| ``` | |
| 2. When prompted: | |
| - `--detectors-include`: `RClone_CVE_2026_41176` | |
| - `--port-ranges-target`: `5572,5573` | |
| 3. Verify results in `/tmp/tsunami-out.json`: | |
| - Port `5572`: `VULNERABILITY_VERIFIED` (`CVE-2026-41176`) | |
| - Port `5573`: Not flagged (patched) |
|
|
||
| The testbed uses Docker Compose to deploy two instances: | ||
| - **Vulnerable instance (`rclone_vulnerable`)**: Rclone `v1.73.4` running on port `5572`. | ||
| - **Patched / Safe instance (`rclone_patched`)**: Rclone `v1.73.5` running on port `5573` with authentication configured. |
Contributor
There was a problem hiding this comment.
Suggested change
| - **Patched / Safe instance (`rclone_patched`)**: Rclone `v1.73.5` running on port `5573` with authentication configured. | |
| - **Patched / Safe instance (`rclone_patched`)**: Rclone `v1.73.5` running on port `5573`. |
dyeddala
force-pushed
the
rclone/CVE-2026-41176
branch
from
October 11, 2026 15:13
4b0a782 to
7b963b6
Compare
Contributor
Author
|
Addressed.As per the comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review.