Repository navigation
Add hostname allowlist and revoked cert hash columns to Registrar - #3249
Conversation
Schema-only change for authenticating EPP client certificates by hostname instead of by pinned fingerprint (go/epp-cert-hostname-auth). Adds two nullable text[] columns to Registrar: - allowed_epp_client_certificate_hostnames: hostnames a registrar has authorized; a CA-issued certificate naming one of them in its SAN is accepted at EPP login. - revoked_client_certificate_hashes: SHA-256 hashes of certificates the registrar has revoked; rejected at login regardless of mechanism. Nothing reads the columns yet; the entity and login changes follow in a separate PR once this has been deployed, per the two-PR schema rule in db/README.md. TAG=agy CONV=2d7c1c2a-4714-4670-84a9-9c5670f8afc3 BUG=http://b/573177136
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements a database schema migration (PR #1 of the 2-PR split mandate) by adding two new columns, allowed_epp_client_certificate_hostnames and revoked_client_certificate_hashes, to the Registrar table. The changes include the new Flyway migration script (V232), an updated Flyway index, updates to the golden schema file, and regenerated ER diagrams. No Java ORM changes are included, adhering to the database consistency guidelines. There are no review comments to evaluate, and I have no additional feedback to provide.
gbrodman
left a comment
gbrodman
left a comment
There was a problem hiding this comment.
@gbrodman reviewed 5 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on CydeWeys and ptkach).
Schema-only change for authenticating EPP client certificates by hostname instead of by pinned fingerprint (go/epp-cert-hostname-auth). Adds two nullable text[] columns to Registrar:
Nothing reads the columns yet; the entity and login changes follow in a separate PR once this has been deployed, per the two-PR schema rule in db/README.md.
TAG=agy
CONV=2d7c1c2a-4714-4670-84a9-9c5670f8afc3
BUG=http://b/573177136
This change is