builtin: declare :list:member as ArgModeInputOutput (fixes #94)

analysis/validation_test.go

@@ -18,7 +18,7 @@ import (
 	"bytes"
 	"embed"
 	"fmt"
-	"path/filepath"
+	"path"
 	"strings"
 	"testing"
 
@@ -85,7 +85,7 @@ func TestCases(t *testing.T) {
 	for _, testCase := range entries {
 		t.Run(testCase.Name(), func(t *testing.T) {
 			file, err := testCases.ReadFile(
-				filepath.Join("test_cases", testCase.Name()))
+				path.Join("test_cases", testCase.Name()))
 			if err != nil {
 				t.Fatal(err)
 			}
@@ -693,6 +693,12 @@ func TestBoundsAnalyzer(t *testing.T) {
 			makeSimpleDecl(atom("foo(X)"), ast.NumberBound),
 			makeSimpleDecl(atom("bar(Y)"), symbols.NewListType(ast.NumberBound)),
 		}),
+		newBoundsTestCase(t, []ast.Clause{
+			clause("foo(X) :- bar(X), :list:member(X, [/a, /b])."),
+		}, []ast.Decl{
+			makeSimpleDecl(atom("foo(X)"), ast.NameBound),
+			makeSimpleDecl(atom("bar(X)"), ast.NameBound),
+		}),
 		newBoundsTestCase(t, []ast.Clause{
 			clause("bar(T) :-	T = fn:string:concat(\"A\", 123)."),
 		}, []ast.Decl{

builtin/builtin.go

@@ -51,7 +51,7 @@ var (
 		symbols.FloatLe:        {ast.ArgModeInput, ast.ArgModeInput},
 		symbols.FloatGt:        {ast.ArgModeInput, ast.ArgModeInput},
 		symbols.FloatGe:        {ast.ArgModeInput, ast.ArgModeInput},
-		symbols.ListMember:     {ast.ArgModeOutput, ast.ArgModeInput},
+		symbols.ListMember:     {ast.ArgModeInputOutput, ast.ArgModeInput},
 		symbols.WithinDistance: {ast.ArgModeInput, ast.ArgModeInput, ast.ArgModeInput},
 		symbols.MatchPair:      {ast.ArgModeInput, ast.ArgModeOutput, ast.ArgModeOutput},
 		symbols.MatchCons:      {ast.ArgModeInput, ast.ArgModeOutput, ast.ArgModeOutput},

engine/seminaivebottomup_test.go

@@ -210,6 +210,32 @@ func TestNegation(t *testing.T) {
 	}
 }
 
+func TestListMemberBound(t *testing.T) {
+	store := factstore.NewSimpleInMemoryStore()
+	prog := []ast.Clause{
+		clause("seen(/a)."),
+		clause("seen(/c)."),
+		clause("approved(X) :- seen(X), :list:member(X, [/a, /b])."),
+		clause("is_member() :- :list:member(/a, [/a, /b])."),
+	}
+	if err := analyzeAndEvalProgram(t, prog, store); err != nil {
+		t.Fatalf("Program evaluation failed: %v", err)
+	}
+	expected := []ast.Atom{
+		atom("approved(/a)"),
+		atom("is_member()"),
+	}
+	for _, a := range expected {
+		if !store.Contains(a) {
+			t.Errorf("expected fact %v not found", a)
+		}
+	}
+	unexpected := atom("approved(/c)")
+	if store.Contains(unexpected) {
+		t.Errorf("unexpected fact %v found", unexpected)
+	}
+}
+
 func TestNegationOrder(t *testing.T) {
 	store := factstore.NewSimpleInMemoryStore()
 	negationProgram := []ast.Clause{