Skip to content

Improve Room transactions when downloading a survey - #3869

Open
andreia-ferreira wants to merge 5 commits into
masterfrom
andreia/3767/improve-loi-db-writes
Open

Improve Room transactions when downloading a survey #3869
andreia-ferreira wants to merge 5 commits into
masterfrom
andreia/3767/improve-loi-db-writes

Conversation

@andreia-ferreira

@andreia-ferreira andreia-ferreira commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Towards #3866 ; #3767

After a survey finishes downloading, saving it locally ran one database transaction per site and then scanned the whole table to prune deleted ones. This caused the initial loading dialog to show for longer than needed, especially for large surveys. This PR improves that by:

@shobhitagarwal1612 PTAL?

@andreia-ferreira andreia-ferreira changed the title Update Room transactions when downloading a survey Improve Room transactions when downloading a survey Aug 5, 2026
@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.74%. Comparing base (c61510d) to head (ad8e2d8).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3869      +/-   ##
============================================
+ Coverage     67.70%   67.74%   +0.04%     
- Complexity     1859     1864       +5     
============================================
  Files           411      411              
  Lines         10857    10868      +11     
  Branches       1425     1426       +1     
============================================
+ Hits           7351     7363      +12     
+ Misses         2767     2766       -1     
  Partials        739      739              
Files with missing lines Coverage Δ
...a/local/room/stores/RoomLocationOfInterestStore.kt 91.48% <100.00%> (+5.77%) ⬆️
...android/repository/LocationOfInterestRepository.kt 61.22% <100.00%> (-0.40%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant