Disconnect LE credit-based channels on invalid SDU lengths - #999
Merged
Merged
Conversation
An SDU length of 0 was also used to mean "length not known yet", so a PDU announcing a zero-length SDU never completed, and every PDU that followed was appended to it without limit. An SDU length above the channel's MTU was accepted and the SDU delivered. A zero-length SDU is now delivered as an empty SDU. An SDU length above the MTU, or more payload than the SDU length announced, now sends a disconnection request, as the TODO asked. PDUs received while the channel is not connected are now dropped, as the log message already said, so a peer that ignores the request cannot keep feeding the channel.
zxzxwu
self-requested a review
October 5, 2026 08:37
zxzxwu
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
LeCreditBasedChannel.on_pduused an SDU length of 0 to mean "length not known yet". A PDU announcing a zero-length SDU therefore never completed, and every PDU that followed was appended to the same buffer without limit. Separately, an SDU length above the channel's MTU was accepted and the SDU delivered.Reproduction on a channel with an MTU of 100 bytes:
Change
All in
LeCreditBasedChannel.on_pdu:TODO: we should disconnect.Testing
tests/l2cap_test.py:test_zero_length_sduandtest_invalid_sdu_length(3 cases). All 4 fail without the fix and pass with it.black -S --check,ruff check, andpylint -Eare clean; mypy reports nothing for the changed files.