Repository navigation
Fix - remove BIG Sync handles on BigSync.terminate to prevent resync failures - #994
Open
markusjellitsch wants to merge 4 commits into
Open
markusjellitsch wants to merge 4 commits into
markusjellitsch wants to merge 4 commits into
Conversation
zxzxwu
reviewed
Sep 28, 2026
zxzxwu
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the fix! Left a couple of small comments.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
BigSync.terminate()sent the terminate command and set the syncstate, but never removed the sync's handle from the device's big_syncs dict nor its BIS link
handles from bis_links. Only the
on_big_sync_lostcallback did that cleanup.Because the stale entries were never removed,
re-syncing the same BIG repeatedly leaked entries until the 240th re-sync (0x00-0xF0 valid range) failed.
How to reproduce
The following test with transmitter (creating a big) and receiver (syncing to the big, then terminating) demonstrates the issue:
The Fix
This PR fixes the above described issue by adding a helper method
_remove_big_syncthat pops the big/bis handles once the BIG sync was terminated. this method is also used inon_big_sync_lost().In addition ,
test_big_sync_and_terminate_255_timeswas added,, which creates and terminates a BIG sync 255times and asserts no stale entries accumulate across the full handle wrap-around.