Skip to content

Update [GULSwizzler ivarObjectForObjects] and add unit tests - #244

Merged
tejasd merged 2 commits into
mainfrom
td/proxy
Aug 25, 2026
Merged

Update [GULSwizzler ivarObjectForObjects] and add unit tests#244
tejasd merged 2 commits into
mainfrom
td/proxy

Conversation

@tejasd

@tejasd tejasd commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

@tejasd

tejasd commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator Author

/gemini review

@tejasd tejasd changed the title WIP: Update [GULSwizzler ivarObjectForObjects] and add unit tests Update [GULSwizzler ivarObjectForObjects] and add unit tests Aug 25, 2026
@tejasd
tejasd marked this pull request as ready for review August 25, 2026 16:49
@tejasd
tejasd requested review from ncooke3 and paulb777 August 25, 2026 16:49

@ncooke3 ncooke3 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How soon would this need to be released?

@paulb777 paulb777 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could there be an existing use case that depends on a weak ivar being swizzled?

@tejasd

tejasd commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator Author

Could there be an existing use case that depends on a weak ivar being swizzled?

The existing usage decided whether to swizzle or not based on the protocol or the superclass of the instance variable - firebase/firebase-ios-sdk#16553.

This change (and the versioning constraints) would result in older versions of the SDK no longer swizzling weak instances - which IIUC would be an improvement (to prevent related crashes).

@tejasd

tejasd commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator Author

How soon would this need to be released?

Ideally ASAP. Based on the versioning rules in https://github.com/firebase/firebase-ios-sdk (assuming this is a minor version bump) - users can benefit from it in https://github.com/firebase/firebase-ios-sdk/blob/main/FirebasePerformance/CHANGELOG.md#12140 (and potentially older).

firebase/firebase-ios-sdk#16553 also fixes it for future versions.

@tejasd
tejasd merged commit 262046d into main Aug 25, 2026
26 checks passed
@tejasd
tejasd deleted the td/proxy branch August 25, 2026 20:21
@ncooke3 ncooke3 mentioned this pull request Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants