Conversation
|
/gemini review |
…to fetch ivars from and update logic to exclude weak ivars
ncooke3
left a comment
There was a problem hiding this comment.
How soon would this need to be released?
paulb777
left a comment
There was a problem hiding this comment.
Could there be an existing use case that depends on a weak ivar being swizzled?
The existing usage decided whether to swizzle or not based on the protocol or the superclass of the instance variable - firebase/firebase-ios-sdk#16553. This change (and the versioning constraints) would result in older versions of the SDK no longer swizzling weak instances - which IIUC would be an improvement (to prevent related crashes). |
Ideally ASAP. Based on the versioning rules in https://github.com/firebase/firebase-ios-sdk (assuming this is a minor version bump) - users can benefit from it in https://github.com/firebase/firebase-ios-sdk/blob/main/FirebasePerformance/CHANGELOG.md#12140 (and potentially older). firebase/firebase-ios-sdk#16553 also fixes it for future versions. |
Updates
[GULSwizzler ivarObjectForObjects]onobjc_loadWeakRetainedvia-[PAGWeakProxy respondsToSelector:]—FPRProxyObjectHelperreads and ISA-swizzles a__weakdelegate ivar firebase/firebase-ios-sdk#16469