fix: catch pubspec.yaml asset loading errors to prevent crashes - #334
Open
stephenmcd wants to merge 1 commit into
Open
fix: catch pubspec.yaml asset loading errors to prevent crashes#334stephenmcd wants to merge 1 commit into
stephenmcd wants to merge 1 commit into
Conversation
Wrap rootBundle.loadString and yaml parsing in a try-catch block inside Configurations._getPackageConfiguration(). Fallback to 'unknown' version instead of crashing if the pubspec.yaml asset cannot be loaded in specific environments (e.g. AAR packaging or custom asset pipelines). Add corresponding unit test. Closes #331
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap rootBundle.loadString and yaml parsing in a try-catch block inside Configurations._getPackageConfiguration(). Fallback to 'unknown' version instead of crashing if the pubspec.yaml asset cannot be loaded in specific environments (e.g. AAR packaging or custom asset pipelines). Add corresponding unit test.
Closes #331
Describe the changes proposed
A clear and concise description of the changes included in this pull request.
Screenshots / Videos
If useful, include any screeshots or screencasts to better explain the change.
Additional context
Add any other context about the change here.