Repository navigation
zavod #50: Рукописные уроки 81–88 - #44
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a7d283d7fa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "import re\n" | ||
| "\n" | ||
| "def find_numbers(text):\n" | ||
| " return [int(value) for value in re.findall(r'\\d+', text)]\n", |
There was a problem hiding this comment.
Preserve signs when extracting integers
For text containing a signed integer, such as find_numbers('температура -12'), the reference implementation returns [12], contradicting the prompt's promise to return all integers. Include an optional sign in the pattern and add a negative-number test, or explicitly narrow the exercise to non-negative digit sequences.
Useful? React with 👍 / 👎.
| }, | ||
| { | ||
| "id": "regex-substitution", | ||
| "subtitle": "sub заменяет, split делит по шаблону", |
There was a problem hiding this comment.
Cover the advertised re.split operation
Lesson 88 is still titled “Замена и разделение” in app/extended_curriculum.py:1008-1013, and this subtitle explicitly promises that split divides by a pattern, but every theory card and question in the handwritten override covers only re.sub; re.split appears nowhere else in the lesson. Because the override wholly replaces the generated theory and questions, learners never receive the advertised splitting material, so add a runnable re.split explanation/exercise or narrow the lesson title and subtitle.
Useful? React with 👍 / 👎.
Рукописные уроки 81–88
Круг: 2
Критерии
Изменённые файлы
app/handwritten/lessons_productivity_regex.pytests/test_handwritten_productivity_regex.py