Repository navigation
zavod #47: Рукописные уроки 57–64 - #42
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HdAtUFHuCYJ3tWqyvJHqGt
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2e5594f8e4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| " header = lines[0].split(',')\n" | ||
| " return [dict(zip(header, line.split(','))) for line in lines[1:]]\n", |
There was a problem hiding this comment.
Parse quoted CSV fields instead of splitting commas
For valid CSV containing a quoted delimiter, such as name,note\nАня,"x,y", this implementation silently returns {'note': '"x'} because split(',') creates an extra cell and zip truncates it. Since the exercise promises to parse CSV rather than an explicitly restricted unquoted format, use CSV-aware parsing or clearly narrow the contract and teach this limitation.
Useful? React with 👍 / 👎.
Рукописные уроки 57–64
Круг: 2
Критерии
Изменённые файлы
app/handwritten/lessons_files_errors.pytests/test_handwritten_files_errors.pyПредложения новых задач