Skip to content

zavod #52: Рукописные уроки 97–104 - #39

Merged
gon7187 merged 2 commits into
mainfrom
zavod/52-rukopisnye-uroki-97-104
Oct 22, 2026
Merged

gon7187 merged 2 commits into
mainfrom
zavod/52-rukopisnye-uroki-97-104

Conversation

@gon7187

@gon7187 gon7187 commented Oct 22, 2026

Copy link
Copy Markdown
Owner

Рукописные уроки 97–104

Круг: 1

Критерии

  • ✓ c1 — tests/test_handwritten_cli_http.py:101,111,117 проверяют восемь уроков, реестр, номера, названия и 120 уроков; отчёт test_round: 67 passed.
  • ✓ c2 — tests/test_handwritten_cli_http.py:128 проверяет общий контракт, исполнение карточек, id вопросов, reference, starter и отсутствие шаблонных фраз; отчёт test_round: 67 passed.
  • ✓ k97 — app/handwritten/lessons_cli_http.py:174; tests/test_handwritten_cli_http.py:236 проверяет обязательные вызовы через run_code; отчёт test_round: 67 passed.
  • ✓ k98 — app/handwritten/lessons_cli_http.py:250; tests/test_handwritten_cli_http.py:248 проверяет порт, отсутствие ключа и нечисловое значение через run_code; отчёт test_round: 67 passed.
  • ✓ k99 — app/handwritten/lessons_cli_http.py:356; tests/test_handwritten_cli_http.py:261 проверяет имя с версией, комментарий и имя без версии через run_code; отчёт test_round: 67 passed.
  • ✓ k100 — app/handwritten/lessons_cli_http.py:469; tests/test_handwritten_cli_http.py:274 проверяет name секции project и отсутствие name через run_code; отчёт test_round: 67 passed.
  • ✓ k101 — app/handwritten/lessons_cli_http.py:580; tests/test_handwritten_cli_http.py:286 проверяет (404, 'Not Found') через run_code; отчёт test_round: 67 passed.
  • ✓ k102 — app/handwritten/lessons_cli_http.py:677; tests/test_handwritten_cli_http.py:295 проверяет извлечение заголовков и отсутствие items через run_code; отчёт test_round: 67 passed.
  • ✓ k103 — app/handwritten/lessons_cli_http.py:769 реализует все четыре группы и неизвестный код; tests/test_handwritten_cli_http.py:309 проверяет обязательные вызовы через run_code; отчёт test_round: 67 passed.
  • ✓ k104 — app/handwritten/lessons_cli_http.py:873; tests/test_handwritten_cli_http.py:322 проверяет вторую страницу и выход за конец списка через run_code; отчёт test_round: 67 passed.
  • ✓ c3 — tests/test_handwritten_cli_http.py:166,174,186,193,208 проверяют порядок карточек, реальные выводы, вопросы на понимание и сходство вариантов; отчёт test_round: 67 passed без пропусков. Карточки и варианты просмотрены вручную в app/handwritten/lessons_cli_http.py:83.
  • ✓ c4 — app/handwritten/lessons_cli_http.py:278,296,388: run=False только для subprocess и tomllib вне белого списка. tests/test_handwritten_cli_http.py:225 проверяет каждый пример раннером и обоснованность run=False; отчёт test_round: 67 passed.

Изменённые файлы

  • app/handwritten/lessons_cli_http.py
  • tests/test_handwritten_cli_http.py

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T23:01:29.462141Z bc256a3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@gon7187
gon7187 merged commit 810eadd into main Oct 22, 2026
3 checks passed
@gon7187
gon7187 deleted the zavod/52-rukopisnye-uroki-97-104 branch October 22, 2026 22:59

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bc256a3af8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +475 to +477
" if line.startswith('[') and line.endswith(']'):\n"
" section = line[1:-1]\n"
" continue\n"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Handle inline comments on TOML table headers

When a valid header has an inline comment, such as [tool.demo] # config, the endswith(']') check does not recognize it and leaves section set to project. A following name = "foreign" is therefore returned as the project name even when [project] has no name, reproducing the exact cross-section error this lesson is intended to prevent.

Useful? React with 👍 / 👎.

Comment on lines +874 to +875
" start = (page - 1) * size\n"
" return items[start:start + size]\n",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reject page numbers below one before slicing

The prompt states that pages are numbered from one and out-of-range pages return an empty list, but negative pages create negative slice bounds and can return real data; for example, paginate([1, 2, 3, 4, 5], -1, 2) returns [2, 3]. Validate page < 1 before computing the slice so the reference solution satisfies its stated contract.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant