Skip to content

Require NZ account number suffix to start with a zero - #273

Open
osasko-gc wants to merge 2 commits into
masterfrom
fix/nz-account-number-suffix
Open

Require NZ account number suffix to start with a zero#273
osasko-gc wants to merge 2 commits into
masterfrom
fix/nz-account-number-suffix

Conversation

@osasko-gc

@osasko-gc osasko-gc commented Sep 11, 2026

Copy link
Copy Markdown

NZ account number suffixes are two digits (00-99). Where they are given as three digits, the leading digit is padding and is always a zero, so 3 digit suffixes not starting with a zero are rejected.

  • NZ account_number_format becomes \d{7}0\d{2}
  • bumps the gem to 1.34.0
  • fixes stale NZ account_number/account_number_suffix examples in the README

Risks

This rejects some details that are valid today. Consuming applications that recompute hashes/derived fields from a stored IBAN, or that re-validate on read, will start getting different results for such an account.

@osasko-gc
osasko-gc force-pushed the fix/nz-account-number-suffix branch from 0e0d694 to 655dfa3 Compare September 11, 2026 10:58
@osasko-gc

Copy link
Copy Markdown
Author

json 3.0 stopped tolerating the //-commented blocks these fixtures used to disable stale rule examples (added in 4fdddbe, 2020), which broke bundle exec rspec on master as of the json 3.0.0 Dependabot bump around 2026-09-07. Rule000300/000900 remain covered by other active cases in germany_unit_test_cases.json; Rule001900 had no active coverage already.

@osasko-gc
osasko-gc force-pushed the fix/nz-account-number-suffix branch from e5e217f to 6412d26 Compare September 11, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant