Require NZ account number suffix to start with a zero - #273
Open
osasko-gc wants to merge 2 commits into
Open
Conversation
osasko-gc
force-pushed
the
fix/nz-account-number-suffix
branch
from
September 11, 2026 10:58
0e0d694 to
655dfa3
Compare
Author
|
|
osasko-gc
force-pushed
the
fix/nz-account-number-suffix
branch
from
September 11, 2026 14:35
e5e217f to
6412d26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NZ account number suffixes are two digits (00-99). Where they are given as three digits, the leading digit is padding and is always a zero, so 3 digit suffixes not starting with a zero are rejected.
NZaccount_number_formatbecomes\d{7}0\d{2}account_number/account_number_suffixexamples in the READMERisks
This rejects some details that are valid today. Consuming applications that recompute hashes/derived fields from a stored IBAN, or that re-validate on read, will start getting different results for such an account.