deps: bidi comes from go-typeset, not a transfer redirect - #5
Merged
Conversation
The bidirectional algorithm moved to its own org, github.com/go-typeset/bidi: it imports nothing at all, so it never belonged under an org whose subject is the font format. This module still resolved the old path, which only answers through a GitHub transfer redirect — and a redirect does not unify module paths, so a graph mixing the two carries two unrelated bidi.Direction types. Raising the go-widgets/go-opentype dependencies to their current releases is what removes it: those modules have migrated, and go.mod now names the real path of every module it resolves rather than a redirected one. Only go.mod and go.sum change. Build, vet and tests are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bidirectional algorithm moved to its own org,
github.com/go-typeset/bidi— it imports nothing at all, so it never belonged under an org whose subject is the font format.This module still resolved
github.com/go-opentype/bidi, a path that only answers through a GitHub transfer redirect. A redirect does not unify module paths: two paths are two different types, so a graph mixing this module with an already-migrated one would carry two unrelatedbidi.Directiontypes.Raising the
go-widgets/go-opentypedependencies to their current releases is what removes it — those modules have migrated. Onlygo.modandgo.sumchange.Verified before opening:
go build ./...,go vet ./...andgo test -count=1 ./...all clean, andgrep go-opentype/bidi go.modreturns nothing. (font_test.go,text.goandunits.goare unformatted onmainalready — left untouched rather than mixed into a dependency change.)