Write an outline of one's own - #7
Merged
Merged
Conversation
A document assembled rather than merged has an outline of its caller's: there is no source outline to carry over, because the pages came from several places and the headings over them are new. Doc.SetOutline writes the bookmarks given rather than the sources' own. An entry pointing at a page this document has not got is left out, and so is everything under it — a heading whose section has gone is not a heading any more. Passing nothing puts the sources' bookmarks back, and DropOutlines still wins over both. This is what a shared edit needs: several people agree on an order of pages drawn from several files, and the headings over them belong to the plan rather than to any of the files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A document assembled rather than merged has an outline of its caller's: there is no source outline to carry over, because the pages came from several places and the headings over them are new.
An entry pointing at a page this document has not got is left out, and so is everything under it — a heading whose section has gone is not a heading any more. Passing nothing puts the sources' bookmarks back, and
DropOutlinesstill wins over both. The same depth and count limits that bound a carried-over outline bound this one.This is what a shared edit needs, where several people agree on an order of pages drawn from several files and the headings over them belong to the plan rather than to any of the files.
100% statement coverage.