Take the reader that decodes a fax, which changes nothing here - #2
Merged
Conversation
reader v0.4.2 -> v0.5.0, which decodes /CCITTFaxDecode. This changes nothing this package produces, and the number is the point of saying so: every one of the 2 268 forms in /Users/Shared/pdfforms was read with both versions -- the whole field tree, every field's value and text and flags, the appearance the file already carries for each of its widgets, and a freshly drawn appearance for each of the 88 168 fillable text fields among the 1 633 real documents -- and the output is byte for byte identical in all 2 268. Both binaries verified with `go version -m`. A form does not carry its own scans, so there was nothing here for a fax decoder to change. It is taken because this package resolves reader alongside four siblings that do need it, and a module of this family lagging its own dependency is how a defect gets shipped twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readerv0.4.2 → v0.5.0. No code change.This changes nothing this package produces, and the number is the point of
saying so.
Measured
Two binaries, each verified with
go version -m:For every one of the 2 268 forms in
/Users/Shared/pdfformsthe harnessdumped, and compared byte for byte:
asks for its appearances to be redrawn, and its default appearance string;
MaxLen, quadding, widget count, button states and option count;probe string of the letters
pdffontv0.3.0 taught the family to read(
Příliš žluťoučký kůň Łódź Gdańsk Iğdır Șoseaua Ķīlis ąčęėįšųū Erdős),including the content stream byte for byte.
The 133 241 figure matches the corpus's own documented field count exactly, which
is the check that the harness was reading the whole thing.
Why it is taken anyway
A form does not carry its own scans, so there was nothing here for a fax decoder
to change. It is taken because this module resolves
readeralongside foursiblings that do need v0.5.0 — and because a module of this family lagging its own
dependency is exactly how a defect gets shipped twice:
pdffontshipped the21-second
reader.Opendenial of service to its callers for one release forprecisely that reason.
Not measured
Wall clock and peak memory. Three other corpus jobs were running, so a timing
figure would be fiction, and there is no output change for one to explain.
Also here
A
.gitignore. This was the only module of the family without one, which is how acoverage profile nearly went in with the previous commit; its five siblings all
ignore exactly this file. (Landed in #1; noted here for completeness.)
Gates
go vet,gofmt, exact 100% statement coverage, nine cross-compile targets, allpass locally with
GOWORK=off CGO_ENABLED=0.