Give a page a time budget, and take the fixes from underneath - #6
Open
tannevaled wants to merge 1 commit into
Open
Give a page a time budget, and take the fixes from underneath#6tannevaled wants to merge 1 commit into
tannevaled wants to merge 1 commit into
Conversation
ops v0.5.0 -> v0.6.0, render v0.7.0 -> v0.8.0, reader v0.4.1 -> v0.4.2,
pdffont -> v0.3.0 indirect. opentype comes along to v0.10.0 because render
v0.8.0 asks for it.
What the workbench gains without asking:
- Annotations are drawn. A filled-in form used to appear empty, because
what a person typed lives in the widget beside the content, not in it.
- Soft masks, and a transparency group drawn as one thing.
- A composite font's identifiers reach its glyphs through the charset, so
a CIDFontType2 subset carrying no cmap no longer hides every glyph.
- A clip is kept as the box it covers rather than as a value for every
pixel of the page.
- A form's field list survives a rotate, so the boxes on the page keep
their meaning.
- An inline image's dictionary is read in a settled order, so a page
carrying both spellings of a key -- /W beside /Width -- no longer draws
differently from one run to the next.
What it had to ask for is the time budget. render v0.8.0 will stop drawing
a page when its time is up and hand back as far as it got, but only if the
caller says how long -- and a browser tab is exactly the caller that cannot
wait: of 59 432 corpus pages, 1 131 were still being drawn after twenty
seconds and one took two hundred and seventy-three. So renderPage sets five
seconds, and shows the part that was drawn instead of treating ErrTimedOut
as a page that cannot be drawn at all. Half a figure is worth more to
somebody scrolling than a sentence saying there was one.
tannevaled
force-pushed
the
bump-pdfkit-deps
branch
from
August 27, 2026 12:57
39cea0c to
a3260b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Measurements are being run now and will be added to this body before review.