Point at the rest of the family - #2
Merged
Merged
Conversation
A reader who lands on one of these has no way of knowing the other six exist, or that there is a documentation site covering all of them. One line, at the foot, saying what each of the others is for.
Page.navigate returns when the navigation begins, not when it has finished, so the first look at the workbench is often at the blank page the browser started on — where the element being waited for does not exist and reading its classes throws. The check took that for a failure. It passed on this machine and failed on a build runner, which is what a race does. A missing element is now not-ready-yet rather than broken.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A reader who lands on one of these has no way of knowing the other six exist, or that there is a documentation site covering all of them.
One line, at the foot, saying what each of the others is for.