Let the browser check run on a build machine - #1
Merged
Conversation
A runner has no user namespaces to put Chrome's renderer in, so Chrome refuses to start at all rather than start unsandboxed. The check now turns the sandbox off when CHROME_NO_SANDBOX says to, which the workflow sets: the only page this browser ever loads is the one the check serves itself, from this machine, over a socket it opened a moment earlier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A runner has no user namespaces to put Chrome's renderer in, so Chrome refuses to start rather than start unsandboxed:
The check turns the sandbox off when
CHROME_NO_SANDBOXsays to, which the workflow sets. The only page this browser ever loads is the one the check serves itself, from this machine, over a socket it opened a moment earlier.