Fix config validation and animation lifecycle - #57
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…lidation-lifecycle # Conflicts: # .fvmrc
RockerFlower
marked this pull request as ready for review
July 8, 2026 06:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The package exposed SingleConfig and RandomConfig, but only CustomConfig rendered. CustomConfig also missed gradient length validation, which could fail later during paint/build with a range error. The widget lifecycle kept animation state in a way that could become stale across widget updates.
Compatibility
This is intended as a non-breaking bugfix. The existing Dart SDK constraint remains unchanged, and CustomConfig keeps its existing constructor shape and nullable public fields.
Validation