Preserve project TOML line endings when writing widgets - #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\n, left\ron untouched lines, and joined modified/inserted lines with bare\n, producing mixed line endings on Windows-ownedgleam.tomlfiles.write_widget,remove_widget, key updates, section insertion, and section removal now detect the file line ending and split/rejoin with it consistently.Fixes glendix-labs/mendraw#10
Verification
gleam test— 115 passed../scripts/verify.sh inner mxpak— passed../scripts/check-all.sh— passed.verify.sh final— passed on retry (family checks, widget build, Lustre E2E, Mendix full E2E); first attempt hit a transient Hex API rate limit.