Validate MPK entry paths before extraction writes - #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zip:unzip(..., [memory])already normalizes upward traversal (../evil.txtbecomesevil.txt).mpk/zip.extractnow rejects empty, absolute,..-containing, and backslash entry names before any cache or project write.../evil.txt, explicit rejection for a real..\evil.txtarchive, nested valid paths, and truncated archives.Fixes glendix-labs/mendraw#3
Verification
gleam test— 107 passed../scripts/verify.sh inner mxpak— passed../scripts/check-all.sh— passed (after fixing workspace public/private ordering rules).verify.sh final— passed (family checks, widget build, Lustre E2E, Mendix full E2E).