Skip to content

Lock missing-key reinsertion in existing TOML sections - #10

Merged
GG-O-BP merged 1 commit into
mainfrom
test/toml-missing-key-reinsertion
Sep 3, 2026
Merged

Lock missing-key reinsertion in existing TOML sections#10
GG-O-BP merged 1 commit into
mainfrom
test/toml-missing-key-reinsertion

Conversation

@GG-O-BP

@GG-O-BP GG-O-BP commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • mendraw#17 reported that the old TOML writer could not re-add a deleted key inside an existing widget section. The rewritten update_key_in_section already supports insertion (before the next section header, or at the end of the document for a final section).
  • This PR locks the exact issue scenario: a manually deleted s3_id is reinserted inside the existing DataGrid section without disturbing the following [other] section, and a missing version key in a final section round-trips through the real parser.

Fixes glendix-labs/mendraw#17

Verification

  • gleam test — 121 passed.
  • ./scripts/verify.sh inner mxpak — passed.
  • ./scripts/check-all.sh — passed.
  • pre-push verify.sh final — passed (family checks, widget build, Lustre E2E, Mendix full E2E).

@GG-O-BP
GG-O-BP merged commit fa897da into main Sep 3, 2026
@GG-O-BP
GG-O-BP deleted the test/toml-missing-key-reinsertion branch September 3, 2026 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[sidecar] toml_writer가 기존 섹션에 없는 키를 추가하지 못함

1 participant