feat(lustre): add keyed application host - #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
glendix/lustre.keyed_host, a typed props-and-render API that preserves a hosted application for an unchanged key and remounts it when the key changesredraw.keyedfor React key assignment while keeping the minimal stable hook-owning host inside the existing Lustre FFI boundaryuse_tearesult andlustre/element/keyeddo not provide host-level remountingEcosystem boundary
Redraw provides key assignment, but
use_teainvokes hooks while its element is being produced. A key applied only after that evaluation cannot remount the hook owner. The small existing-boundaryKeyedHostdefers the render callback into a stable React component;redraw.keyedthen keys that component. No new FFI file or application-specific datasource logic is introduced.Verification
./scripts/verify.sh inner glendixGLENDIX_MENDIX_URL=http://127.0.0.1:18080 ./scripts/verify.sh finalGG-O-BP/mendix-ironcalc-spreadui) with its localSpreadUiHost/keyed_hostJavaScript removed and this branch used as a path dependency:gleam format --check src testgleam checkgleam build --warnings-as-errorsgleam test --runtime bunbun test test/*.test.mjsgleam run -m glendix/install --runtime bungleam run -m glendix/build --runtime bunCloses #6