Skip to content

Bump js-yaml from 4.3.1 to 5.2.3 #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bump js-yaml from 4.3.1 to 5.2.3 #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
},
"dependencies": {
"execa": "^9.6.1",
"js-yaml": "^4.3.1"
"js-yaml": "^5.2.3"

@aditya-scio aditya-scio Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From Glean Code Writer

Glean PR Reviewer

This bump moves js-yaml to v5, whose ESM entrypoint is exposed through named exports. The PR updates the dependency, but src/check-client-releases.js on this branch still imports the package as a default export:

import yaml from "js-yaml";

That script calls yaml.load(content), so it will fail when the module is loaded under v5. Please update that source file to use the named export:

import { load } from "js-yaml";

const spec = load(content);

I cannot anchor this comment directly on src/check-client-releases.js because it is not part of this PR diff.

},
"devDependencies": {
"prettier": "^3.9.6",
Expand Down
10 changes: 5 additions & 5 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading