[rig-claude] Improve Claude dynamic-workflow compatibility for rig - #328
Merged
Merged
Conversation
…on table
The schema conversion table in claude-workflow-conversion.md was missing
{ type: "number" } → s.number and { type: "string", const } → s.literal.
Both are common JSON Schema patterns in Claude dynamic workflows. Adding
them makes the mechanical schema port fully covered by the table.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
pelikhan
approved these changes
Aug 1, 2026
pelikhan
marked this pull request as ready for review
August 1, 2026 20:08
Contributor
Author
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅ |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
Author
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /codebase-design and /grill-with-docs — no blocking issues found.
3 table rows added filling a real gap in the schema conversion reference. s.number and s.literal are valid helpers, placement is logical, no links broken.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 15.9 AIC · ⌖ 4 AIC · ⊞ 6.3K
Comment /matt to run again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compatibility gap addressed
The schema conversion table in
skills/rig/references/claude-workflow-conversion.mdwas missing two common JSON Schema types that Claude dynamic-workflow users frequently encounter when porting schemas:{ type: "number" }→s.number(and with description){ type: "string", const: "done" }→s.literal("done")Every other scalar type (
string,integer,boolean,enum,array,object,anyOf/null, optional) was already in the table. The gap meant a user converting a schema with a numeric field or a const-string field had to infer the mapping themselves.Why this improves transfer
Claude dynamic workflows routinely use
{ type: "number" }for scores, confidence values, and measurements, andconstfor discriminant fields in tagged unions. Without the table rows, a user porting a schema must searchagent-api.mdorrig.tsto discovers.numberands.literal. With the rows, the conversion is fully mechanical within the reference file.Files changed
skills/rig/references/claude-workflow-conversion.md— added 3 table rows (number, number+description, const/literal)Validation
Only docs changed; no typecheck or test run required per project rules. Links verified — no references modified.
Remaining intentional differences
{ effort: "high" }has no rig equivalent (not modeled).agentType: "Explore"has no built-in read-only agent type.These are documented in the Behavior differences section of the same file.