fix(presets): tolerate non-UTF-8 legacy commands - #3896
Open
marcelsafin wants to merge 1 commit into
Open
Conversation
Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Makes legacy command frontmatter parsing tolerant of non-UTF-8 content while preserving the default replacement strategy.
Changes:
- Handles decoding failures during best-effort frontmatter parsing.
- Adds regression coverage for invalid UTF-8 command files.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/specify_cli/presets/__init__.py |
Catches frontmatter decoding failures. |
tests/test_presets.py |
Tests fallback to replace. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
replacestrategy when command content is not UTF-8Testing
uvx ruff@0.15.0 check src tests.venv/bin/pytest tests/test_presets.py -q(509 passed).venv/bin/pytest -q(6106 passed, 176 skipped)AI disclosure
GitHub Copilot helped identify the incomplete best-effort boundary and review the implementation. I reproduced the failure and validated the final change with targeted and full test suites.