feat(openai): Gate embeddings input collection on data_collection - #6977
Open
ericapisani wants to merge 3 commits into
Open
feat(openai): Gate embeddings input collection on data_collection#6977ericapisani wants to merge 3 commits into
ericapisani wants to merge 3 commits into
Conversation
Honour `_experiments["data_collection"]["gen_ai"]["inputs"]` in `_set_embeddings_input_data`. When the experiment is set, it takes precedence over `send_default_pii` (though `include_prompts=False` still wins); when unset, fall back to the previous PII-based behavior. `gen_ai.operation.name` and the request model are now always set on the span, even when input collection is skipped. Add tests covering the precedence matrix (sync + async) and input shapes under disabled input collection. Refs PY-2588
Contributor
Codecov Results 📊✅ 96342 passed | ⏭️ 6343 skipped | Total: 102685 | Pass Rate: 93.82% | Execution Time: 342m 30s 📊 Comparison with Base Branch
➖ Removed Tests (1)View removed tests
All tests are passing successfully. ✅ Patch coverage is 91.67%. Project has 2514 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 89.91% 89.88% -0.03%
==========================================
Files 193 193 —
Lines 24832 24835 +3
Branches 8912 8920 +8
==========================================
+ Hits 22326 22321 -5
- Misses 2506 2514 +8
- Partials 1417 1420 +3Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Honour
_experiments["data_collection"]["gen_ai"]["inputs"]in_set_embeddings_input_data. When the experiment is set, it takes precedence oversend_default_pii(thoughinclude_prompts=Falsestill wins); when unset, fall back to the previous PII-based behavior.gen_ai.operation.nameand the request model are now always set on the span, even when input collection is skipped.Add tests covering the precedence matrix (sync + async) and input shapes under disabled input collection.
Refs PY-2588