Skip to content

Keep replay tests off the Docker boundary - #290

Open
webdevtodayjason wants to merge 1 commit into
mainfrom
fable/issue-221
Open

webdevtodayjason wants to merge 1 commit into
mainfrom
fable/issue-221

Conversation

@webdevtodayjason

@webdevtodayjason webdevtodayjason commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Startup replay tests could reach the real get_backend factory when a test exercised the append core without replacing append_solo_instance. On a host with Docker, that path could create ainode-vllm-node-solo and collide with a real engine.

Decision

Patch ainode.engine.backends.get_backend in the replay module's autouse fixture so every replay test stays behind a fake backend boundary. Keep the backend command-construction tests meaningful by continuing to instantiate those backends directly and patch their subprocess seam. Add a regression test that calls the real append core and proves the resulting engine is the fixture fake with the requested model config.

Proof

  • .venv/bin/pytest -q tests/test_replay_bind_window.py tests/test_browser_federation.py: 50 passed in 7.39s
  • .venv/bin/ruff check: All checks passed
  • Docker container census after the focused run: no ainode-vllm* containers

Changelog

  • Keep startup replay unit tests from creating real vLLM Docker containers.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant