[WIP] Compute reactions only on selected fields - #7391
Open
anne-glerum wants to merge 9 commits into
Open
anne-glerum wants to merge 9 commits into
anne-glerum wants to merge 9 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No need to comment at the moment, I want to see what the tester says first.
This PR adds an argument to the
compute_reactions()function so that reactions can be computed on only a subset of fields. In this PR, this is used to eliminate fields tracked by particles from the operator splitting. For example in the case of tracking viscoelastic stresses on particles, the operator split takes place directly on the particles, and should not happen on the fields constructed from the particle properties.This PR is also in preparation for #6909, where we want to compute reactions for some fields before the nonlinear solver loop, and for some fields after the solver loop (e.g. porosity vs stress updates).
I have added a test, but as noted in the prm file header, I am not sure whether the result is correct - the porosity in the beam is higher than the test I based it on says it should be. However, moving the beam to be the last compositional field does not change the results, so it seems not related to the new indexing in
compute_reactions(). Also, both reaction solvers produce the higher porosity.For all pull requests:
For new features/models or changes of existing features: