Conversation
Author
|
@mgorny Friendly ping? I'm still seeing this on my system. |
Member
|
Sorry, missed it. That said, I wonder if a more reasonable thing to do wouldn't be to record this as a stray directory, and therefore have ek remove it. |
Author
|
Good point, reworked to do so. |
mgorny
reviewed
Sep 21, 2026
Comment on lines
+130
to
+131
| else: | ||
| kernels[(ver, "bls")] = k |
Member
There was a problem hiding this comment.
Thanks but the else branch makes little sense here, given the loop never breaks, so it will always be executed.
Sorry for bothering you with major refactor, but I'm thinking of:
- assigning the new
Kernel()straight tokernels[...] - passing that to
append_kernel_files()and ignoring the return value
If you don't want to do that, let me know and I'll take over.
Member
There was a problem hiding this comment.
Well, I meant removing the k helper variable, not adding more of it.
If a bls directory is empty, eclean-kernel fails with a KeyError. This can happen when too many kernels build up and the /boot partition is filled to the point that writing the initramfs fails. Fixes gentoo#60 e.g. File "/home/peter/eclean-kernel/.venv/bin/eclean-kernel", line 10, in <module> 12:42 [54/433] sys.exit(setuptools_main()) ~~~~~~~~~~~~~~~^^ File "/home/peter/eclean-kernel/ecleankernel/__main__.py", line 391, in setuptools_main sys.exit(main(sys.argv[1:])) ~~~~^^^^^^^^^^^^^^ File "/home/peter/eclean-kernel/ecleankernel/__main__.py", line 236, in main kernels = layout.find_kernels(exclusions=exclusions) File "/home/peter/eclean-kernel/ecleankernel/layout/blspec.py", line 130, in find_kernels kernels[(ver, "bls")].all_files.append( ~~~~~~~^^^^^^^^^^^^^^ KeyError: ('7.0.1-gentoo-dist', 'bls')
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a bls directory is empty, eclean-kernel fails with a KeyError. This can happen when too many kernels build up and the /boot partition is filled to the point that writing the initramfs fails.
Fixes #60
e.g.
File "/home/peter/eclean-kernel/.venv/bin/eclean-kernel", line 10, in 12:42 [54/433]
sys.exit(setuptools_main())
~~~~~~~~~~~~~~~^^
File "/home/peter/eclean-kernel/ecleankernel/main.py", line 391, in setuptools_main
sys.exit(main(sys.argv[1:]))
~~~~^^^^^^^^^^^^^^
File "/home/peter/eclean-kernel/ecleankernel/main.py", line 236, in main
kernels = layout.find_kernels(exclusions=exclusions)
File "/home/peter/eclean-kernel/ecleankernel/layout/blspec.py", line 130, in find_kernels
kernels[(ver, "bls")].all_files.append(
~~~~~~~^^^^^^^^^^^^^^
KeyError: ('7.0.1-gentoo-dist', 'bls')