Repository navigation
Conversation
… progress) The race hunt on the Prometheus web UI (web/ui/mantine-ui): the harness, the first sessions' results, the duplicate-request fix and its test as a patch, and the pull request draft. The report's results sections are filled in by the next commit, when the remaining sessions have run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fqwfq2rZJASoQ4owhyDZp2
…sults and report All 28 sessions (21 explore sessions at 300, 600 and 900 ms and 7 runs without GenClass, 224 page loads): the page matched a fresh load of the final state in 224 of 224. Explore's seven RACE verdicts are false reports (form fields named by per-load random ids; a server-side tie in the TSDB status top-10), written up with GenClass's other problems. The tree view's duplicate leaf request is a non-race fix left to the owner. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fqwfq2rZJASoQ4owhyDZp2
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status: needs owner decision.
I hunted for races in the Prometheus 3.x web UI (
web/ui/mantine-ui, prometheus/prometheusmainat 4a933f8) and found none.Separately, I found a real non-race bug: the query tree view sends each leaf node's
/api/v1/querytwice and aborts the first. There is a two-line fix with a Vitest test. GenClass did not find this as a race, so the owner decides whether it is worth sending as a plain bug fix.Files
docs/adoption/hunts/prometheus-mantine-ui.md: the report (setup, scenarios, results table, every explore line classified, why the UI does not race, the duplicate request, GenClass problems, time spent, how to reproduce).docs/adoption/hunts/prometheus-mantine-ui.patch: the fix and test against upstream4a933f89fa96c56ad69e7c02dc5f40e06d93440e, 59 changed lines.docs/adoption/hunts/prometheus-mantine-ui-issue.md: the pull request draft in Prometheus' template, plus an optionalbug_report.ymlissue, the disclosure paragraph and the "before sending" checklist.docs/adoption/hunts/prometheus-mantine-ui/: the harness (hunt.mjs,run-all.sh,requests.mjs,summarise.mjs), the hunt'sprometheus.ymlandrules.yml,results/(28 files, 384 KB in all, each under 30 KB) andsummaries/.docs/adoption/hunts/README.md: one new row.To send (only if the owner says yes)
mainand apply the patch.requests.mjsagainst both builds.pnpm --filter @prometheus-io/mantine-ui exec vitest run src/pages/query/TreeNode.test.tsx, thenCI=true pnpm run testandpnpm run lintinweb/ui.git commit -s(DCO, the sender's own name).ui: send each query tree node's request once, using the body inprometheus-mantine-ui-issue.md. It addresses the web/ui owner (juliusv) as CONTRIBUTING.md asks for trivial fixes. No issue is needed first.endTime={null}; the patch was checked on its head.Measured
Duplicate request (
requests.mjs, plain Playwright,vite previewproduction builds, 8 loads each):mainTest: on
mainit fails 3 of 3 runs; with the fix it passes 3 of 3. The full UI suite passes (18 files, 208 tests); eslint, prettier and tsc are clean.Hunt (seed 1, 6 seeded runs per session, slow_ms 300/600/900):
False-report rate on the correct app: all 7 RACE verdicts (42 of 126 seeded runs) are false.
Problems with GenClass itself (report section 9)
id. Ids generated at random per load (Mantine'suseId) cause false RACE verdicts: 6 sessions, 36 of 36 seeded runs. The baselines' noise filter removes exact names, not the shape.fetchblocks the schedule. The UI's notifications stream (fetch-event-source) holds up delivery for its first 10 s, so 3 to 5 holds run out per load, baselines included (624 in 168 loads). With the stream blocked: 0 in 4 of 4 loads, and each load took about 7 s instead of about 16 s. Suggested: treattext/event-streamresponses as delivered once their headers arrive.GenClass.init/data-manualinjection, while Ghost's usesGENCLASS_CONFIG.Time
About 2 h 15 min. The 50-minute matrix ran in the background while I worked on the fix, test and drafts.
The branch is
claude/bold-faraday-i2fpxs, the session's assigned branch, instead ofadopt/prometheus-mantine-ui. Nothing was sent to any other repository.Generated by Claude Code