Repository navigation
Conversation
Re-ran the hunt on vendurehq/vendure master f97b187 (2026-11-02, 3.8.1): the double submit still reproduces without GenClass (Create 21 of 48 trials, 15 duplicate entities; Update 25 of 48), and the rebased patch brings both to 0 of 48. The unit tests and the e2e tests fail 3 of 3 on master and pass 3 of 3 with the patch. The e2e test moves into e2e/tests/catalog/collections.spec.ts, per Vendure's AGENTS.md, and cleans up only the collections its own worker created. The drafts recommend a new dashboard issue (linking #2117, #4884, #5007) over a comment on #2117, and gain the AI-assistance paragraph. The report has a dated Refresh section (9), and vendure-refresh/ holds the summary and the summariser. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fqwfq1QeJKRrvtwRy2QWNe
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status: ready to send.
What
I re-ran the Vendure dashboard double-submit hunt on
vendurehq/venduremasteratf97b187(2026-11-02, 3.8.1).useDetailPagedetail page sends the mutation twice, and Create makes two entities.e2e/tests/catalog/collections.spec.ts, as Vendure'sAGENTS.mdasks, and its cleanup no longer races between parallel workers.No dashboard double submit has been filed upstream since the hunt date.
Files:
docs/adoption/hunts/vendure.md: new status header and section 9, "Refresh (2026-11-03)".docs/adoption/hunts/vendure.patch: rebased; applies tof97b187and toaba3e9c; 4 files, +240 / −9.docs/adoption/hunts/vendure-issue.md: the new-issue decision, the "before filing" checklist (session items done), the issue and PR texts with updated facts and the AI-assistance paragraph.docs/adoption/hunts/vendure-refresh/summary.jsonandsummarize.mjs: every number below, with the script that produced them from the harness's raw runs.docs/adoption/hunts/README.md: the Vendure row.To send (a person, from a personal account, after the owner's OK)
repo:vendurehq/vendureonce more for the queries listed in the draft.DB=sqlite bun run populate && DB=sqlite bun run dev:direct, double-click Create on a new collection, and see two collections.vendure-issue.mdusing the bug template (blank issues are off), and note its number#NNNN.vendurehq/vendureand branch frommaster. Applyvendure.patch, thensed -i 's/#2117/#NNNN/g'on its four files.packages/dashboard, runnpx vitest run src/lib/framework/form-engine/use-generated-form.spec.tsxandCI=true VITE_TEST_PORT=5176 npx playwright test --config e2e/playwright.config.ts e2e/tests/catalog/collections.spec.ts -g "Issue #NNNN".fix(dashboard): submit a detail form only once on double-click, with bodyFixes #NNNN. Relates to #2117.masterwith the drafted text, and sign the CLA when the bot asks.If asked: the fix is client-side only. #5007 (in 3.8.0) stops duplicate translation rows but not duplicate entities, and all counts were measured with it in place.
Measured (2026-11-03)
All runs are on production dashboard builds against the SQLite dev server, with presses sent through CDP 0, 30, 80 and 150 ms apart. Each sweep has 3 trials per page and gap, over 4 pages.
master, no GenClassTests:
masterand pass 3/3 patched.master(2 mutations each) and pass 3/3 patched.collections.spec.ts(27 tests) and--repeat-each=3pass,check-typesis clean, and the dashboard unit suite passes (972 passed, 4 skipped).GenClass duplicate witness, Create only:
master: 24 of the 25 doubled trials (missed one Facet trial at a 30 ms gap).Problems with GenClass itself
timer 0msfalsestale-writenow appears on 12 of 12 clean patched runs on every page. On 2026-10-24 it was about half.stale-writefindings on base-ui component state after user clicks.stale-writefindings duplicate the witness about seven times over per double submit, which drownsgenclass_findings.vendure-ecommerce/vendure, but the search API rejects that name; the canonical name isvendurehq/vendure.Details are in report section 9.6.
Checks
Docs-only change under
docs/adoption/. No runtime, MCP, test or model-visible file was touched, and no dependency was added. GenClass was built frommain(c1c9e14) only to run the harness.Notes for the reviewer
Start with report sections 9.3 and 9.4.
Not run:
vitest.plugin.config.mts, for lack of time; they touch nothing the patch changes.Branch: the session was assigned
claude/magical-wright-izmnjr, so the branch is notadopt/vendure-refresh. Time spent: about 1 h 15 min.Generated by Claude Code