Add optional property-based testing suite (src/test/prop)

.github/workflows/fork-ocr-model-check.yml

@@ -0,0 +1,18 @@
+# Weekly check for a newer Claude Opus on Bedrock; opens/updates one issue here
+# when OCR_BEDROCK_MODEL is behind. Notify-only (GITHUB_TOKEN cannot write
+# Actions variables). Logic lives in gburd/ci-workflows.
+
+name: OCR model self-check
+
+on:
+  schedule:
+    - cron: '0 12 * * 1'   # Mondays 12:00 UTC
+  workflow_dispatch:
+
+jobs:
+  check:
+    uses: gburd/ci-workflows/.github/workflows/ocr-model-check.yml@v1
+    with:
+      aws_role_arn: ${{ vars.AWS_ROLE_ARN }}
+      aws_region: ${{ vars.AWS_REGION }}
+      bedrock_model: ${{ vars.OCR_BEDROCK_MODEL }}

.github/workflows/fork-ocr-review.yml

@@ -0,0 +1,43 @@
+# AI PR review (Claude Opus on Bedrock). Logic and review rules live in
+# gburd/ci-workflows so this fork's master carries a stub instead of ~1000
+# lines that have to be rebased onto upstream forever.
+#
+# Needs repo variables AWS_ROLE_ARN, AWS_REGION, OCR_BEDROCK_MODEL. Auth is
+# GitHub OIDC; no static AWS keys. See the ci-workflows README.
+
+name: OCR AI Review
+
+on:
+  pull_request:
+    # Note: no draft filter — drafts are reviewed too.
+    types: [opened, synchronize, reopened, ready_for_review]
+  issue_comment:
+    types: [created]
+  workflow_dispatch:
+    inputs:
+      pr_number:
+        description: 'PR number to review'
+        required: true
+        type: number
+
+# One review per PR; cancel superseded runs to save Bedrock spend.
+concurrency:
+  group: ocr-review-${{ github.event.pull_request.number || github.event.issue.number || github.event.inputs.pr_number }}
+  cancel-in-progress: true
+
+jobs:
+  review:
+    # Comment events only when the comment is on a PR and starts with the
+    # trigger keyword; PR events and manual dispatch always.
+    if: |
+      github.event_name == 'pull_request' ||
+      github.event_name == 'workflow_dispatch' ||
+      (github.event_name == 'issue_comment' && github.event.issue.pull_request &&
+        (startsWith(github.event.comment.body, '/open-code-review') ||
+         startsWith(github.event.comment.body, '@open-code-review') ||
+         startsWith(github.event.comment.body, '/pg-history')))
+    uses: gburd/ci-workflows/.github/workflows/ocr-review.yml@v1
+    with:
+      aws_role_arn: ${{ vars.AWS_ROLE_ARN }}
+      aws_region: ${{ vars.AWS_REGION }}
+      bedrock_model: ${{ vars.OCR_BEDROCK_MODEL }}

.github/workflows/fork-sync-upstream.yml

@@ -0,0 +1,48 @@
+# Keep this fork's master rebased on postgres/postgres master, carrying only
+# the fork-owned CI stubs (.github/workflows/fork-*.yml). The workflows they
+# call, and the OCR review rules, live in gburd/ci-workflows.
+#
+# Requires the SYNC_TOKEN secret: a PAT with repo+workflow scope. The default
+# GITHUB_TOKEN is not allowed to push commits that touch .github/workflows/,
+# and every commit we carry does.
+
+name: Sync from upstream
+
+on:
+  schedule:
+    - cron: '17 */3 * * *'
+  workflow_dispatch:
+
+concurrency:
+  group: fork-sync-upstream
+
+permissions:
+  contents: read
+
+jobs:
+  sync:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v6
+        with:
+          fetch-depth: 0
+          token: ${{ secrets.SYNC_TOKEN }}
+
+      - name: Rebase master onto upstream
+        run: |
+          set -euo pipefail
+          git config user.name "github-actions[bot]"
+          git config user.email "github-actions[bot]@users.noreply.github.com"
+          git remote add upstream https://github.com/postgres/postgres.git
+          git fetch --no-tags upstream master
+
+          # Master carries fork CI only. Anything else means work landed here
+          # that belongs on a branch; force-rebasing it on a timer would be wrong.
+          if git diff --name-only upstream/master...HEAD |
+               grep -v '^\.github/workflows/fork-'; then
+            echo "::error::master carries non-CI changes (listed above); move them to a branch"
+            exit 1
+          fi
+
+          git rebase upstream/master
+          git push --force-with-lease

configure.ac

@@ -241,6 +241,22 @@ PGAC_ARG_BOOL(enable, injection-points, no, [enable injection points (for testin
               [AC_DEFINE([USE_INJECTION_POINTS], 1, [Define to 1 to build with injection points. (--enable-injection-points)])])
 AC_SUBST(enable_injection_points)
 
+#
+# Property-based tests (src/test/prop), built on libhegel.  TAP is NOT
+# required: pg_prop is a standalone C program that emits TAP output and runs on
+# its own.  When --enable-tap-tests is also given, the Perl drivers are run as
+# part of the TAP suite; otherwise the binary is still built (run it directly).
+# The actual presence of libhegel's header and library is checked further
+# below, once --with-includes / --with-libraries are in effect.
+#
+PGAC_ARG_BOOL(with, hegel, no,
+              [build property-based tests (requires libhegel; uses TAP when --enable-tap-tests)])
+AC_SUBST(with_hegel)
+# Export the extra library directories so the property-test Makefile can add
+# them to pg_prop's rpath; libhegel is typically installed outside the system
+# loader path and reached via --with-libraries.
+AC_SUBST(LIBRARY_DIRS)
+
 #
 # Block size
 #
@@ -1416,6 +1432,18 @@ failure.  It is possible the compiler isn't looking in the proper directory.
 Use --without-zlib to disable zlib support.])])
 fi
 
+# libhegel for property-based tests.  The C ABI header has no PostgreSQL
+# dependencies; the engine ships as a plain shared library, libhegel_c.  Both
+# must be reachable via --with-includes / --with-libraries (or a system path).
+if test "$with_hegel" = yes; then
+  AC_CHECK_HEADER(hegel.h, [],
+                  [AC_MSG_ERROR([header file <hegel.h> is required for --with-hegel
+Point --with-includes at libhegel's include directory.])])
+  AC_CHECK_LIB(hegel_c, hegel_version, [],
+               [AC_MSG_ERROR([library 'hegel_c' (libhegel) is required for --with-hegel
+Point --with-libraries at libhegel's library directory.])])
+fi
+
 if test "$with_libcurl" = yes ; then
   PGAC_CHECK_LIBCURL
 fi

meson.build

@@ -1827,6 +1827,54 @@ endif
 
 
 
+###############################################################
+# Library: libhegel (property-based testing engine)
+###############################################################
+
+# Property-based tests (src/test/prop) require:
+#   1. -Dprop_tests=enabled (explicit opt-in; default disabled), and
+#   2. libhegel's header and shared library present (found via
+#      extra_include_dirs / extra_lib_dirs or a system path).
+# TAP is NOT required: the pg_prop binary is a standalone C program that emits
+# TAP output and runs on its own (./pg_prop <area> ...), against any cluster
+# PGHOST/PGPORT point at for the SQL-oracle areas.  When TAP tests are also
+# enabled the Perl drivers (t/001_prop.pl, t/002_sql_props.pl) are registered
+# as the 'prop' meson suite for convenience -- they start a throwaway cluster
+# and run the binary -- but the suite is a methodology on top of the harness,
+# not gated by TAP.  With -Dprop_tests=enabled a missing libhegel is a hard
+# error so the opt-in cannot silently do nothing.
+prop_tests_enabled = false
+prop_tests_tap = false
+libhegel = not_found_dep
+propopt = get_option('prop_tests')
+if not propopt.disabled()
+  # The C ABI header has no PostgreSQL dependencies; the engine ships as a
+  # plain shared library named libhegel_c.  Look for both.
+  libhegel_h = cc.has_header('hegel.h',
+    args: test_c_args, include_directories: postgres_inc,
+    required: propopt)
+  libhegel_lib = cc.find_library('hegel_c',
+    dirs: postgres_lib_d, required: propopt)
+  if libhegel_h and libhegel_lib.found()
+    libhegel = declare_dependency(dependencies: libhegel_lib)
+    prop_tests_enabled = true
+    # Register the Perl TAP drivers only when TAP is available; without it the
+    # binary still builds and can be run by hand.
+    prop_tests_tap = tap_tests_enabled
+    if not tap_tests_enabled
+      message('property-based tests: building pg_prop; TAP drivers not ' +
+              'registered (tap_tests disabled) -- run the binary directly')
+    endif
+  elif propopt.enabled()
+    error('prop_tests requires libhegel (hegel.h and libhegel_c); ' +
+          'point --extra-include-dirs / --extra-lib-dirs at its install')
+  else
+    message('property-based tests disabled: libhegel not found')
+  endif
+endif
+
+
+
 ###############################################################
 # Library: zstd
 ###############################################################
@@ -4322,6 +4370,7 @@ summary(
     'icu': icu,
     'ldap': ldap,
     'libcurl': libcurl,
+    'libhegel (prop_tests)': libhegel,
     'libnuma': libnuma,
     'liburing': liburing,
     'libxml': libxml,

meson_options.txt

@@ -46,6 +46,9 @@ option('tap_tests', type: 'feature', value: 'auto',
 option('injection_points', type: 'boolean', value: false,
   description: 'Enable injection points')
 
+option('prop_tests', type: 'feature', value: 'disabled',
+  description: 'Enable property-based tests (requires libhegel and TAP tests)')
+
 option('PG_TEST_EXTRA', type: 'string', value: '',
   description: 'Enable selected extra tests. Overridden by PG_TEST_EXTRA environment variable.')
 

src/Makefile.global.in

@@ -211,6 +211,8 @@ enable_dtrace	= @enable_dtrace@
 enable_coverage	= @enable_coverage@
 enable_injection_points = @enable_injection_points@
 enable_tap_tests	= @enable_tap_tests@
+with_hegel	= @with_hegel@
+LIBRARY_DIRS	= @LIBRARY_DIRS@
 
 python_includespec	= @python_includespec@
 python_libdir		= @python_libdir@

src/test/Makefile

@@ -34,12 +34,15 @@ endif
 ifeq ($(with_ssl),openssl)
 SUBDIRS += ssl
 endif
+ifeq ($(with_hegel),yes)
+SUBDIRS += prop
+endif
 
 # We don't build or execute these by default, but we do want "make
 # clean" etc to recurse into them.  (We must filter out those that we
 # have conditionally included into SUBDIRS above, else there will be
 # make confusion.)
-ALWAYS_SUBDIRS = $(filter-out $(SUBDIRS),examples kerberos icu ldap ssl)
+ALWAYS_SUBDIRS = $(filter-out $(SUBDIRS),examples kerberos icu ldap ssl prop)
 
 # We want to recurse to all subdirs for all standard targets, except that
 # installcheck and install should not recurse into the subdirectory "modules".

src/test/meson.build

@@ -26,3 +26,7 @@ if icu.found()
 endif
 
 subdir('perl')
+
+if prop_tests_enabled
+  subdir('prop')
+endif