Skip to content

fix: Self approval - generated types overlap workflow #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shubham-fyle merged 1 commit into from
Oct 27, 2026
Merged

fix: Self approval - generated types overlap workflow #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions scripts/generated-types-model-overlap-workflow.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ export const verifyGeneratedTypesApproval = async ({
const { owner, repo } = context.repo;
const pull_number = context.issue.number;
const headSha = context.payload.pull_request.head.sha;
const authorLogin = context.payload.pull_request.user.login.toLowerCase();
const reviews = await github.paginate(github.rest.pulls.listReviews, {
owner,
repo,
Expand All @@ -177,6 +178,7 @@ export const verifyGeneratedTypesApproval = async ({
(review) =>
review.state === "APPROVED" &&
review.commit_id === headSha &&
review.user.login.toLowerCase() !== authorLogin &&
approvedReviewerLogins.has(review.user.login.toLowerCase()),
);

Expand Down
Loading