fix: reduce buildScoreCache example size and clean up export_abnFit example - #261
LeonidasZhak wants to merge 1 commit into
Conversation
…xample - Reduce N from 1e6 to 100 in buildScoreCache() example (issue furrer-lab#254) - Remove unnecessary data() call from export_abnFit() example - Fix missing distributions in export_abnFit() example (b4, b5)
|
@learbuehrer could you take over the review of this? |
|
Thanks for the fix and for the pull request. I’m perfectly happy with change 1 — reducing For change 2, I agree that The updated mydists <- list(
b1 = "binomial", p1 = "poisson", g1 = "gaussian",
b2 = "binomial", p2 = "poisson", b3 = "binomial",
g2 = "gaussian", b4 = "binomial", b5 = "binomial",
g3 = "gaussian")This would both include all 10 variables and preserve the ordering of There is also another issue I noticed when testing the example. So the example currently fails with Thanks again for addressing the documentation issues! |
Summary
This PR addresses issue #254 by making the following documentation improvements:
Changes
R/build_score_cache.R (line 283): Reduced N from 1e6 to 100 in the buildScoreCache() example. 1 million observations is excessive for a simple example; 100 is sufficient to demonstrate the workflow.
R/export.R (lines 152-161): Cleaned up export_abnFit() example:
data(ex1.dag.data)call (data is available via lazy loading)library(abn)call (not needed in examples)b4 = "binomial"andb5 = "binomial"to match the 10 variables inex1.dag.dataman/buildScoreCache.Rd and man/export_abnFit.Rd: Updated Rd files to match roxygen source
Validation
Related Issues
export_abnFit#240 (export_abnFit example)