Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The updated skip path can replace an existing scalar value with None instead of preserving it.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Cleans up scrambling behavior, improves HTTPX client lifecycle management, refines Sisu schemas, and expands scrambler tests.
Changes:
- Adds comprehensive scrambler coverage across integrations.
- Corrects StudyRight and PublicPerson schemas and scrambling.
- Ensures HTTPX clients close and avoids mutating configured scrambler lists.
| File | Description |
|---|---|
tests/scramblers/osuva/test_osuva_plan_scrambler.py |
Tests Osuva plan scrambling. |
tests/scramblers/osuva/__init__.py |
Initializes Osuva tests. |
tests/scramblers/ori/test_tuition_fee_obligation_period_scrambler.py |
Tests tuition-fee scrambling. |
tests/scramblers/ori/test_thesis_scrambler.py |
Tests thesis scrambling. |
tests/scramblers/ori/test_study_right_scrambler.py |
Tests StudyRight scrambling and validation. |
tests/scramblers/ori/test_private_person_scrambler.py |
Tests private-person scrambling. |
tests/scramblers/ori/test_ori_worfklow_scramblers.py |
Tests workflow scrambling. |
tests/scramblers/ori/test_mobility_period_scrambler.py |
Tests mobility-period scrambling. |
tests/scramblers/ori/test_attainment_scrambler.py |
Tests attainment nested fields. |
tests/scramblers/ori/test_attained_qualification_scrambler.py |
Tests qualification scrambling. |
tests/scramblers/ori/__init__.py |
Initializes ORI tests. |
tests/scramblers/kori/test_kori_person_scrambler.py |
Tests public-person scrambling. |
tests/scramblers/kori/__init__.py |
Initializes KORI tests. |
tests/scramblers/ilmo/test_enrolment_scrambler.py |
Tests enrolment scrambling. |
tests/scramblers/ilmo/__init__.py |
Initializes ILMO tests. |
tests/scramblers/__init__.py |
Initializes scrambler tests. |
funidata_utils/utils.py |
Changes missing-key handling. |
funidata_utils/sis_integration/exports.py |
Avoids mutating scrambler configuration. |
funidata_utils/schemas/sisu/study_right.py |
Refines StudyRight field types. |
funidata_utils/schemas/sisu/public_person.py |
Corrects the titles collection type. |
funidata_utils/request_utils/httpx_requests.py |
Closes synchronous HTTPX clients. |
funidata_utils/request_utils/async_httpx_requests.py |
Closes asynchronous HTTPX clients. |
funidata_utils/data_scramblers/study_right.py |
Corrects nested list scrambling. |
funidata_utils/data_scramblers/kori_person.py |
Produces list-shaped titles. |
funidata_utils/data_scramblers/generic_sis_scramble.py |
Makes dropper state instance-specific. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
xTooth
previously approved these changes
Sep 21, 2026
xTooth
left a comment
xTooth
left a comment
Contributor
There was a problem hiding this comment.
Went over the changes both manually and using some help from claude and copilot the current changes look fine to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StudyRightsandPublicPersons