Skip to content

BS-168: Workflow scrambler vol 1 - #59

Merged
rrimpila merged 11 commits into
mainfrom
BS-168
Sep 18, 2026
Merged

rrimpila merged 11 commits into
mainfrom
BS-168

Conversation

@EssKayz

@EssKayz EssKayz commented Sep 14, 2026 •

Copy link
Copy Markdown
Member

Added workflow scrambler for Ori Workflow entities

TODO?;

  • check through each different type both for the WorkFlow base, and for the application subtypes 🪦 (Local sisu dev data doesn't seem to contain examples of all types, so will have to figure out how)
  • more unit tests for different type and application types

@EssKayz
EssKayz marked this pull request as ready for review September 15, 2026 13:25

@rrimpila rrimpila left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just from reading through the scramblers against swagger, I have confusion regarding the handling of the recommendations fields. I didn't yet test against actual data, will proceed with it tomorrow.

Recommendations have been scrambled for CustomAttainment and CustomModuleContent (even though it doesn't list the fields in swagger, do they still exist in data?), but are not touched for PriorLearningInclusion, PriorLearningSubstitution, or ModuleAttainment, which list these fields in swagger. Should they be?

Workflow scramblers for RequiredModuleContent and DegreeProgrammeAttainment also have the fields defined as none, even though they're not listed in swagger.

Comment thread funidata_utils/data_scramblers/workflow_scrambler.py Outdated
Comment thread funidata_utils/data_scramblers/workflow_scrambler.py Outdated
Comment thread funidata_utils/data_scramblers/workflow_scrambler.py Outdated
Comment thread funidata_utils/data_scramblers/workflow_scrambler.py Outdated

@rrimpila rrimpila left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of field checks

Comment thread funidata_utils/data_scramblers/workflow_scrambler.py Outdated
Comment thread funidata_utils/data_scramblers/workflow_scrambler.py Outdated
Comment thread funidata_utils/data_scramblers/workflow_scrambler.py Outdated
Comment thread funidata_utils/data_scramblers/workflow_scrambler.py Outdated
Comment thread funidata_utils/data_scramblers/workflow_scrambler.py Outdated

@rrimpila rrimpila left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M

As far as this is all understandable

@rrimpila
rrimpila merged commit b445296 into main Sep 18, 2026
3 checks passed
@rrimpila
rrimpila deleted the BS-168 branch September 18, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants