fix: map native uuid column types to string - #129
Merged
Merged
Conversation
Since Laravel 11 the column type comes from the database schema instead of Doctrine DBAL, so uuid columns report `uuid` (PostgreSQL, MariaDB) or `uniqueidentifier` (SQL Server). Neither was in the mappings, and MapReturnType fell back to `unknown`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #107
Problem
UUID columns are generated as
unknowninstead ofstring. Since Laravel 11 the column type comes from the database schema instead of Doctrine DBAL, so$table->uuid()is reported as:uuidunknownstringuuidunknownstringuniqueidentifierunknownstringchar(36)stringstringvarcharstringstringThe existing
guidentry (#52) is the Doctrine DBAL name, which Laravel no longer reports, anduuidwas not part of the Laravel 11 mappings added after #71.Solution
Add
uuidanduniqueidentifierto the native column type mappings, next tochar,varcharand the other types from #71.Tests
The test suite runs on SQLite, where uuid columns already map to
string, so the new test callsMapReturnTypedirectly with the real mappings fromGetMappings. It fails before the change (unknown) and passes after it. Locally on PHP 8.4: 131 tests passing,pint --testandphpstanclean.