Repository navigation
Start Data Slot components with their page script - #334
Merged
Merged
Conversation
Dialog, Sheet and NavigationMenu import their controller statically and call create(), as the other Data Slot components do, instead of loading it per media query. The on-media helper, src/lib/dialog.ts, the on-media registry item and the responsive activation docs are removed. `media` stays on the three components as a deprecated prop with no effect, so installs that pass it still type-check. Header blocks keep `fold` and close their sheet or navigation menu when the layout hides it at that breakpoint, which also releases the scroll lock. Every Data Slot component also binds new roots on astro:after-swap, before a site's own astro:page-load listeners run after ClientRouter navigation; create() skips roots that are already bound. All eight styles are regenerated. Liquid and the published @data-slot ^1.1.2 dependencies are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for fulldev-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
silveltman
marked this pull request as ready for review
October 26, 2026 11:32
Merged
silveltman
pushed a commit
that referenced
this pull request
Oct 26, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## fulldev-ui@0.26.0 ### Minor Changes - [#328](#328) [`53e43a0`](53e43a0) Thanks [@silveltman](https://github.com/silveltman)! - Add an optional Image component with Astro Picture formats, responsive sources and an unchanged single-image default. - [#334](#334) [`6ed056f`](6ed056f) Thanks [@silveltman](https://github.com/silveltman)! - Data Slot components start with their page script, with no loading helper. Dialog, Sheet and NavigationMenu no longer load their controller per media query: `media` is still accepted but has no effect, and the registry no longer has the `on-media` item or `src/lib/dialog.ts`; a site that installed them can delete `src/lib/on-media.ts` and `src/lib/dialog.ts` once nothing imports them. Header blocks 1 to 5 take `fold="lg"`, the default, or `fold="xl"` for the breakpoint between their mobile sheet and desktop navigation, and close whichever one the layout hides at that breakpoint, which also releases the sheet's scroll lock. Every Data Slot component also binds new roots on `astro:after-swap`, so a site's own `astro:page-load` command after ClientRouter navigation reaches a started controller. Co-authored-by: fulldev-release[bot] <336258566+fulldev-release[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dialog, Sheet and NavigationMenu import their Data Slot controller statically and call
create(), like the other Data Slot components, instead of loading it per media query (#331 to #333).onMediahelper,src/lib/dialog.ts, theon-mediaregistry item, the responsive activation docs and their tests. No custom loader, no loading props.mediastays accepted on the three components with no effect and is not rendered, so hosted-registry installs since Load responsive menu behavior at the header breakpoint #331 that pass it still type-check.fold="lg" | "xl"and close the sheet or navigation menu the layout hides at that breakpoint, which releases the scroll lock.astro:after-swap, before a site's ownastro:page-loadlisteners after ClientRouter navigation; publishedcreate()skips bound roots.@data-slot/*^1.1.2 and Liquid are unchanged. All eight styles regenerated.Sites that installed the hosted helpers can delete
src/lib/on-media.tsandsrc/lib/dialog.tsonce nothing imports them.Validation at
6f8b6aaed:vp run checkpasses (988 files, 0 errors/warnings/hints; one existing knip configuration hint; registry matches). Unit 33/33. Build: 0 critical, 503 existing warnings, 357 hints. Browser 67/67 over Chromium, Firefox and WebKit, including all five headers at both folds (resize closing, scroll unlock, keyboard), ClientRouter teardown and a site page-load command after navigation.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.