Distinguish omitted and None defaults in FSMap.pop - #2136
Open
betacatsling wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FSMap.pop(key, None)currently raises for missing keys because the implementation conflates an explicitNonedefault with an omitted default. Use a sentinel and handle lookup failure inpop, matchingMutableMappingsemantics.Tests exercise memory and local mappings, explicit
Noneand other falsy defaults, missing keys without a default, and retrieval/removal of existing values. The twoNonecases fail on the unchanged base. With the fix, mapping and adjacent local/memory/DirFS suites give 379 passed, 16 skipped. Ruff lint/format andgit diff --checkpassed.AI assistance was used for implementation and local verification.
Fixes #2135.