You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey @anjaliratnam-msft I'm thinking we hold off updating any of the URL parsing for now as end users can set a different endpoint, they just have to use the account_url and account_name parameters in tandem. I put an example of it in the original GitHub issue: #402 (comment)
Mainly, to my understanding the abfs://<file_system>@<account_name>.dfs.core.windows.net/<path>/<file_name> format was specifically to handle the ABFS driver style of URIs and I'm not sure if it supports URIs outside of dfs.core.windows.net per the documentation: https://learn.microsoft.com/en-us/azure/storage/blobs/data-lake-storage-introduction-abfs-uri#uri-syntax. So, I'm hesitant to start supporting different URIs in adlfs especially if the ABFS driver does not support these URIs and because there is already a way to specify different endpoint in adlfs via parameters.
I'm thinking maybe we can repurpose this PR to update the documentation on how to connect to different endpoints? Support of Microsoft OneLake is a similar story (where a different endpoint needs to be set to use with adlfs): #515 So maybe we can include that in the doc update as well? Thoughts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the documentation to instruct users how to set different endpoints. This resolves #402.