fix: Support role names and IDs for SSC local user management - #1090
Open
SangameshV wants to merge 1 commit into
Open
fix: Support role names and IDs for SSC local user management#1090SangameshV wants to merge 1 commit into
SangameshV wants to merge 1 commit into
Conversation
SangameshV
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes SSC local user creation and update operations to support roles specified either by role ID or role name.
Previously, commands such as
fcli ssc ac create-local-userandssc ac update-local-userwould fail when a role name was provided, even though the CLI help indicated that both role names and IDs were supported. The underlying SSC API accepts only role IDs, causing requests with role names to be rejected.Changes:
This change ensures the implementation matches the documented behaviour and provides a more user-friendly experience by allowing users to specify roles using either format.