Skip to content

perf: improve TFORM CopySpectator performance #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jodavies merged 1 commit into from
Sep 15, 2026
Merged

perf: improve TFORM CopySpectator performance #905

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions sources/threads.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2667,7 +2667,11 @@ int ThreadsProcessor(EXPRESSIONS e, WORD LastExpression, WORD fromspectator)
The number of terms in the expression is in e->counter
*/
thrbufsiz2 = thrbufsiz = AC.ThreadBucketSize-1;
if ( ( e->counter / ( numberofworkers * 5 ) ) < thrbufsiz ) {
/* CopySpectator expressions have a one-term expression prototype in the
* scratch file, regardless of how many terms the spectator contains. Don't
* use this prototype to determine bucket size, or we'll end up with single-term
* buckets and bad performance. Just use thrbufsiz in this case. */
if ( ! fromspectator && ( e->counter / ( numberofworkers * 5 ) ) < thrbufsiz ) {
thrbufsiz = e->counter / ( numberofworkers * 5 ) - 1;
if ( thrbufsiz < 0 ) thrbufsiz = 0;
}
Expand Down Expand Up @@ -2922,7 +2926,9 @@ Found2:;
/*
There is room in the bucket. Fill yet another term.
*/
if ( GetTermP(B0,tt) == 0 ) { endofinput = 1; break; }
if ( ( fromspectator
? GetFromSpectator(tt,fromspectator-1)
: GetTermP(B0,tt) ) == 0 ) { endofinput = 1; break; }
dd++;
thr->totnum++;
dd += AN0.deferskipped;
Expand Down Expand Up @@ -2973,7 +2979,9 @@ Found2:;
/*
There is room in the bucket. Fill yet another term.
*/
if ( GetTermP(B0,tt) == 0 ) { endofinput = 1; break; }
if ( ( fromspectator
? GetFromSpectator(tt,fromspectator-1)
: GetTermP(B0,tt) ) == 0 ) { endofinput = 1; break; }
/*
Same bracket?
*/
Expand Down
Loading