Repository navigation
TAMU Sprint18 Staging - #176
Merged
Merged
Conversation
… as appropriate initialization. Remove all of the `@NotNull` annotations. We shouldn't have the **JSON** handler be more opinionated. We can better use **Java** logic to parse and handle the situation. This better allows for providing defaults. This reduces some of the problems with **Jackson's** highly opinionated, fickle, and very subject to breaking change designs. Add `@ColumnDefault` to provide the default where possible. In any case where there is a `columnDefinition` is use, the `@ColumnDefault` cannot be used. Instead, directly specify the default within the `columnDefinition`. Use constant variables where possible, however, many cannot be used because **Java** complains that they are too dynamic to be used. In those cases, unfortunately, static values must be hard coded into the string itself. This is less maintainable, but the situation is forced by **Java's** inflexible design in this case. This can be looked at in the future where we could redefine some global statics or other behavioral change to reduce this problem. Such changes are largely out of scope for this issue. The `ScriptTask` is udpated to use a `SCRIPT_FORMAT_DEFAULT` at a package level so that the unit test can better utilize this. The whole `scriptFormat` vs extension logic should be revisited in the future. We really shouldn't have these extra steps and fields to swap between. Many of the text fields should instead be `TEXT` rather than `VARCHAR`. Under the hood, `VARCHAR` is essentially a `TEXT` with some restrictions. However, `TEXT` operates far better and cleaner than `VARCHAR`. Only in places where it is easy and obvious, change `VARCHAR` (the implicit default) explicitly to `TEXT`. This should prevent problems where much of the text data is not a safe or sane limit. Get rid of any `@Size` limitations that clearly should not exist. Any that is questionable or uncertain is left as-is. Set `nullable` to `falee` where possible that things have defaults being added. There are some fields that have comments noting that they cannot have this set to `false` when it otherwise should. These will have to be re-reviewed at a later date to confirm/deny if the problem they are working around is resolved or not. The default for `includeAttachment` is not a boolean but instead a string of either `true` or `false`. This is because of the use of **Freemarker** on that field. Fixing this to utilize **Camunda's/Operaton's** own expression handler would require too much out of scope changes to handle here. Explicitly add a comment where needed to document this behavior. The `Workflow` is no longer completely missing the initialization of `Setup`. Update unit tests accordingly. For unit tests that happened to be updated, change the arguments stream logic to the more recent practices. The new practices have shown to have less odd problems. We should migrate to the new approach over time or via a separate issue when we have the chance (outside of this issue).
Add class level static constants to make changes easier and more maintainable. This will allow for improving the unit tests. Only update the unit tests that needed to be updated to pass the current coverage requirements.
MODWRKFLOW-85: Provide common/sane defaults during pre-process to act as appropriate initialization.
MODWRKFLOW-84: Upgrade folio-spring-supoort to v10.0.1.
|
lacarbo05
approved these changes
Oct 26, 2026
rmathew1011
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed